Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding on-off button, fixing reverse text #328

Merged
merged 1 commit into from
Aug 17, 2023
Merged

adding on-off button, fixing reverse text #328

merged 1 commit into from
Aug 17, 2023

Conversation

aatmanvaidya
Copy link
Collaborator

This pull request aims to add a feature and resolve a bug.

  1. An On/Off button is added
  • this is a custom toggle switch that allows users to turn Uli on and off. A reload of the page is required for changes to be implemented.
  • A reload is also required when the user login's to Uli for the first time, i.e. activates an account.
  1. Issue Uli makes comment text appear reversed on Google Docs #314 is also fixed in this PR.
  • Uli no longer makes the text revered in text input areas.

@ghost
Copy link

ghost commented Aug 17, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@duggalsu duggalsu merged commit 7eff2ac into tattle-made:main Aug 17, 2023
2 checks passed
@aatmanvaidya aatmanvaidya deleted the on-off-button branch August 26, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duggalsu duggalsu duggalsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aatmanvaidya @duggalsu